Offline unit tests for GzippedJsonDownloaderTest and JsonDownloaderTest #9699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
cd app; ant test
on the master branch results in test errors. I noticed these errors after applying #9698 but they were also present before, only less noticeable:This PR resolves existing test errors 🎉
Cons
Pros
If these tests were intended to test actual data download then this PR should probably be dropped.
However, if the intention was to test deserialization of JSON data (which I believe it looks like) then perhaps these tests could be renamed in another PR to clarify the intent.
All Submissions:
New Feature Submissions:
Changes to Core Features: