Skip to content

Added deprecation warning for gRPC MonitorService #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2022
Merged

Added deprecation warning for gRPC MonitorService #1648

merged 3 commits into from
Feb 1, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 1, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Added deprecation warning for gRPC MonitorService

@cmaglie cmaglie self-assigned this Feb 1, 2022
@cmaglie cmaglie requested a review from a team February 1, 2022 11:15
@cmaglie cmaglie added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Feb 1, 2022
@cmaglie cmaglie added this to the arduino-cli 0.21.0 milestone Feb 1, 2022
@per1234 per1234 added the topic: gRPC Related to the gRPC interface label Feb 1, 2022
per1234
per1234 requested changes Feb 1, 2022
View reviewed changes
@cmaglie cmaglie force-pushed the add_deprecation_warn branch from 2dd7270 to 04d3a92 Compare February 1, 2022 13:48
@cmaglie cmaglie merged commit e9ade7e into arduino:master Feb 1, 2022
@cmaglie cmaglie deleted the add_deprecation_warn branch February 1, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@per1234 per1234 per1234 approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: documentation Related to documentation for the project topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Milestone
arduino-cli 0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @silvanocerza @per1234