-
-
Notifications
You must be signed in to change notification settings - Fork 63
Update node modules #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix protoc action using deprecated API
passes all tests with |
@rsora Tested in our ci flow, works and resolves #13 The our ci flow tested in solo-io/gloo#3874 , the successful run: https://github.com/solo-io/gloo/pull/3874/checks?check_run_id=1408007411 |
@kdorosh thanks!
|
I just ran |
I see @kdorosh, may I ask you to test again in your CI the current I did an upgrade and a bit of dev dependencies cleanups. In the meantime, I'm setting up a test env, but maybe you are quicker than me, I lost a bit of my grip on Github Actions 😸 |
current arduino master works with our ci, tested in solo-io/gloo#3875 (the passing check https://github.com/solo-io/gloo/pull/3875/checks?check_run_id=1408161055) closing this PR since #16 handles it more cleanly thanks @rsora ! |
Thanks @kdorosh for your support, this nice interaction reminded me why I signed to be an OSS maintainer for Arduino 👍 I'm preparing a tag and a release for the Action in the next minutes, keep your eyes peeled 😸 |
updates node modules per
npm install
to ensure the changes in #12 are properly picked up to actually resolve #13Fix came from our fork that is working for us. Please wait to merge until I confirm this works