-
Notifications
You must be signed in to change notification settings - Fork 341
Add github actions workflows #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustup default nightly | ||
rustup component add rustfmt | ||
cargo install mdbook | ||
rustc --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see the install-mdbook script? That way saves quite a bit of time compared to the cargo install mdbook
.
However, the script is fragile because it ultimately relies on a specific release filename pattern and it would be nice if we could have a more general solution. (This is currently an issue for another CI related PR here).
I think a better way might be to create a docker image based on the official image (or slim or docs.rs) with all of the tools we need (deadlinks, mdbook, tarpaulin?) pre-installed. Then we could use the container.image setting to set the environment so that stuff is available without having to rebuild it.
Another github action could handle docker image related tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this would be really nice, and it would probably worth doing this in a follow-up!
Perhaps it's worth opening an issue for this on https://github.com/actions-rs/meta/issues also; I agree that having a general solution for this would probably be very valuable to a lot of people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo install mdbook
should be avoided, it adds ~8 min of build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, long. I will fix it tonight, so take a moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me; I think we should merge this and run it together with Travis for a little bit to see how it works out. If it turns out it works well we can migrate entirely by turning off Travis.
Thanks heaps!
bors r+ |
Bors seems to hang. |
Co-Authored-By: Yoshua Wuyts <[email protected]>
I fixed install mdbook. Please re-review 🙇 |
bors r+ |
Bors breaks on this. I'll merge it in good faith to test. |
background
close: #246