Skip to content

Add pull_request event to github actions hooks #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Oct 1, 2019

#253

I forgot to add pull_request event hooks.
Probably necessary, but what about?

@k-nasa
Copy link
Member Author

k-nasa commented Oct 1, 2019

GitHub actions worked. Would have been necessary

スクリーンショット 2019-10-01 10 50 28

@k-nasa k-nasa force-pushed the fix_github_actions branch from eef6465 to 7ea3f4d Compare October 1, 2019 14:16
@k-nasa k-nasa force-pushed the fix_github_actions branch from 1784e93 to c947cf4 Compare October 1, 2019 14:24
@k-nasa
Copy link
Member Author

k-nasa commented Oct 1, 2019

Ok. I fixed.
However, is ci not working when pushed to master branch?

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Oct 1, 2019

However, is ci not working when pushed to master branch?

Not sure; in general all of our commits are through PRs anyway, and if Bors works then we don't need to run the extra CI run on master merges.

It looks like Clippy is failing though; not sure what's going on as it's a lot of JSON output.

edit: ah I just saw #270

@k-nasa
Copy link
Member Author

k-nasa commented Oct 2, 2019

@yoshuawuyts My imagination is that this access token is mine (the person who pushed it) and I don't have write access, so it may have failed.

token: ${{ secrets.GITHUB_TOKEN }}

@yoshuawuyts
Copy link
Contributor

Alright then; let's merge this and see if it works 🤞

@yoshuawuyts yoshuawuyts merged commit 6bae6b1 into async-rs:master Oct 2, 2019
@k-nasa k-nasa deleted the fix_github_actions branch October 3, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants