Adds try_for_each combinator #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Oct 1, 2019
src/lib.rs
Outdated
| @@ -47,6 +47,7 @@ | |||
| #![doc(test(attr(allow(unused_extern_crates, unused_variables))))] | |||
| #![doc(html_logo_url = "https://async.rs/images/logo--hero.svg")] | |||
| #![recursion_limit = "1024"] | |||
| #![feature(try_trait)] | |||
There was a problem hiding this comment.
Depending on a nightly feature may be tricky for us because it means we wont' be able to run on stable for the 1.39 release. I'm thinking it may perhaps be better to scope try_for_each to Result for now, and mention this as a limitation to the lang team.
There was a problem hiding this comment.
Ok, but how does std work then? (i haven't had a moment to look closely atm)
yoshuawuyts
reviewed
Oct 1, 2019
yoshuawuyts
approved these changes
Oct 2, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2019
269: Adds try_for_each combinator r=yoshuawuyts a=montekki This should probably be hidden behind the unstable feature. --- Ref: #129 Stdlib: https://doc.rust-lang.org/beta/std/iter/trait.Iterator.html#method.try_for_each Co-authored-by: Fedor Sakharov <[email protected]>
Build failed
|
|
It looks like nightly is currently broken; https://github.com/async-rs/async-std/pull/269/checks?check_run_id=243557011 passed, so going to go ahead and merge this manually. Thanks heaps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be hidden behind the unstable feature.
Ref: #129
Stdlib: https://doc.rust-lang.org/beta/std/iter/trait.Iterator.html#method.try_for_each