-
Notifications
You must be signed in to change notification settings - Fork 341
Adds try_for_each combinator #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
use std::marker::PhantomData; | ||
use std::ops::Try; | ||
use std::pin::Pin; | ||
|
||
use crate::future::Future; | ||
use crate::stream::Stream; | ||
use crate::task::{Context, Poll}; | ||
|
||
#[doc(hidden)] | ||
#[allow(missing_debug_implementations)] | ||
pub struct TryForEeachFuture<S, F, T, R> { | ||
stream: S, | ||
f: F, | ||
__from: PhantomData<T>, | ||
__to: PhantomData<R>, | ||
} | ||
|
||
impl<S, F, T, R> TryForEeachFuture<S, F, T, R> { | ||
pin_utils::unsafe_pinned!(stream: S); | ||
pin_utils::unsafe_unpinned!(f: F); | ||
|
||
pub(crate) fn new(stream: S, f: F) -> Self { | ||
TryForEeachFuture { | ||
stream, | ||
f, | ||
__from: PhantomData, | ||
__to: PhantomData, | ||
} | ||
} | ||
} | ||
|
||
impl<S, F, R> Future for TryForEeachFuture<S, F, S::Item, R> | ||
where | ||
S: Stream, | ||
S::Item: std::fmt::Debug, | ||
F: FnMut(S::Item) -> R, | ||
R: Try<Ok = ()>, | ||
{ | ||
type Output = R; | ||
|
||
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
loop { | ||
let item = futures_core::ready!(self.as_mut().stream().poll_next(cx)); | ||
|
||
match item { | ||
None => return Poll::Ready(R::from_ok(())), | ||
Some(v) => { | ||
let res = (self.as_mut().f())(v); | ||
if let Err(e) = res.into_result() { | ||
return Poll::Ready(R::from_error(e)); | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on a nightly feature may be tricky for us because it means we wont' be able to run on stable for the 1.39 release. I'm thinking it may perhaps be better to scope
try_for_each
toResult
for now, and mention this as a limitation to the lang team.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but how does
std
work then? (i haven't had a moment to look closely atm)