[AVR] Implement getCmpLibcallReturnType(). #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Loved reading your debugging steps, surprised the fix is so straightforward Added one indentation nitpick, after that I'm happy to merge this and then commit it to LLVM proper |
dylanmckay
reviewed
Sep 23, 2017
lib/Target/AVR/AVRISelLowering.h
Outdated
| @@ -75,6 +75,11 @@ class AVRTargetLowering : public TargetLowering { | |||
| MVT getScalarShiftAmountTy(const DataLayout &, EVT LHSTy) const override { | |||
| return MVT::i8; | |||
| } | |||
|
|
|||
| MVT::SimpleValueType getCmpLibcallReturnType() const override { | |||
| return MVT::i8; | |||
There was a problem hiding this comment.
Can you switch this to use two-space indentations?
This fixes the issue (rust-lang#75) with floating-point comparisons generating broken code. By default, LLVM assumes these comparisons return 32-bit values, but ours are 8-bit.
exscape
force-pushed
the
float-comp-fix
branch
from
ddd554a to
f7a473a
Compare
|
Huh, I didn't notice. Fixed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the avr-rust issue (avr-rust/rust-legacy-fork#75) with floating-point comparisons generating broken code.
By default, LLVM assumes these comparisons return 32-bit values, but ours are 8-bit.