Skip to content

Removal of secure-random in favour of crypto-browserify #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2014
Merged

Removal of secure-random in favour of crypto-browserify #247

merged 3 commits into from
Jul 28, 2014

Conversation

dcousens
Copy link
Contributor

ecurve was bumped to 1.0.0, no reason not to use that, given the only changes since 0.10.0 was removed support for the secp224r1 curve, and a typo.

Now using crypto-browserify 3.0.0 so we can drop another dependency (secure-random).

@dcousens
Copy link
Contributor Author

Refactored PR to take advantage of browserify/crypto-browserify#45. Thanks @kyledrake :)

@dcousens dcousens changed the title Ecurve and non-custom crypto-browserify Removal of secure-random in favour of crypto-browserify Jul 28, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a8d1a52 on dcousens:ecurve into ca0c56f on bitcoinjs:master.

@dcousens dcousens mentioned this pull request Jul 28, 2014
@Shic1983
Copy link

Sound cool to me. 1.1.0 with txbuilder looks good.

@@ -1,8 +1,7 @@
var assert = require('assert')
var crypto = require('../src/crypto')
var crypto = require('crypto')
var crypto2 = require('../src/crypto')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of the name here. Seems like crypto2 is only used once so why not var sha256 = require('../src/crypto').sha256?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, will apply a suitable fix directly.

weilu added a commit that referenced this pull request Jul 28, 2014
Removal of secure-random in favour of crypto-browserify
@weilu weilu merged commit 6e1bbe8 into bitcoinjs:master Jul 28, 2014
@dcousens dcousens deleted the ecurve branch July 28, 2014 14:55
@dcousens dcousens mentioned this pull request Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants