Removal of secure-random in favour of crypto-browserify #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored PR to take advantage of browserify/crypto-browserify#45. Thanks @kyledrake :) |
dcousens
changed the title
Merged
|
Sound cool to me. 1.1.0 with txbuilder looks good. |
| @@ -1,8 +1,7 @@ | |||
| var assert = require('assert') | |||
| var crypto = require('../src/crypto') | |||
| var crypto = require('crypto') | |||
| var crypto2 = require('../src/crypto') | |||
There was a problem hiding this comment.
Not a big fan of the name here. Seems like crypto2 is only used once so why not var sha256 = require('../src/crypto').sha256?
There was a problem hiding this comment.
Agreed, will apply a suitable fix directly.
weilu
added a commit
that referenced
this pull request
Jul 28, 2014
Removal of secure-random in favour of crypto-browserify
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecurve was bumped to
1.0.0, no reason not to use that, given the only changes since0.10.0was removed support for thesecp224r1curve, and a typo.Now using
crypto-browserify3.0.0 so we can drop another dependency (secure-random).