Wallet test fixes #280
Merged
Wallet test fixes #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var fee = 14570 | ||
| var tx = wallet.createTx(to, value) | ||
| assert.equal(tx.outs.length, 1) | ||
| var tx1 = wallet.createTx(to, value - 546) |
There was a problem hiding this comment.
I assume this is just a clean-up and unrelated to the kill sinon specific change?
Edit: Just read your commit comment where you mentioned it :) Cool
|
+1 like |
|
We should probably still isolate the issue with sinon before shrugging it off though. |
|
Removed sinon-removing commit. Turns out the problem was very obscure, but none the less a fault in the test logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the suggestion in #247,
this PR removes the use ofsinoninTransactionand instead tests that theTransactionis exactly as it should be since the hash is deterministic.It also makes a few fixes thanks to jshint and re-works a test in
Walletwhich was not testing the desired behaviour.