Skip to content

Add linkup command to improve link functionality #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

kylecarbs
Copy link
Member

No description provided.

The linkup command is the successor to coder-cloud. It enables port-forwarding via URL, uses WebRTC internally, and will enable greater linking functionality longer-term. A Link extension will be published once this is merged. We are not removing the old link functionality yet... we eventually will, but want to ensure a smooth transition.
@kylecarbs kylecarbs requested a review from a team as a code owner September 9, 2021 21:24
if ! [ -f ./lib/linkup ]; then
echo "Downloading Link agent..."

# for arch; we do not use OS from lib.sh and get our own.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love comments ❤️

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #4128 (a815d60) into main (bc3acb0) will increase coverage by 0.23%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4128      +/-   ##
==========================================
+ Coverage   64.22%   64.46%   +0.23%     
==========================================
  Files          36       37       +1     
  Lines        1873     1891      +18     
  Branches      379      380       +1     
==========================================
+ Hits         1203     1219      +16     
- Misses        569      571       +2     
  Partials      101      101              
Impacted Files Coverage Δ
src/node/main.ts 42.55% <83.33%> (+2.78%) ⬆️
src/node/link.ts 91.66% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3acb0...a815d60. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

✨ Coder.com for PR #4128 deployed! It will be updated on every commit.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 9, 2021

Code scanning results / Trivy

Heads-up: Trivy failed due to a vulnerability. I will fix in a separate branch and you can rebase once it's merged in

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 10, 2021

The PR has been merged! Please rebase on main!

@jsjoeio jsjoeio added this to the 3.12.0 milestone Sep 10, 2021
@@ -28,7 +28,8 @@
"ms-vscode.remotehub",
"ms-vscode.remotehub-insiders",
"GitHub.remotehub",
"GitHub.remotehub-insiders"
"GitHub.remotehub-insiders",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs This will need to be adjusted in https://github.com/cdr/vscode/blob/code-server/product.json and merged into the code-server branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Doing it now!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'll tackle this after the all-hands. Gotta prep!

Feel free to tackle if you have time!

@GirlBossRush GirlBossRush modified the milestones: 3.12.0, 3.12.1 Sep 10, 2021
@GirlBossRush
Copy link
Contributor

GirlBossRush commented Sep 15, 2021

Tracked in #4171

@jsjoeio jsjoeio deleted the link branch March 22, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants