-
Notifications
You must be signed in to change notification settings - Fork 6k
Add linkup command to improve link functionality #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The linkup command is the successor to coder-cloud. It enables port-forwarding via URL, uses WebRTC internally, and will enable greater linking functionality longer-term. A Link extension will be published once this is merged. We are not removing the old link functionality yet... we eventually will, but want to ensure a smooth transition.
if ! [ -f ./lib/linkup ]; then | ||
echo "Downloading Link agent..." | ||
|
||
# for arch; we do not use OS from lib.sh and get our own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love comments ❤️
Codecov Report
@@ Coverage Diff @@
## main #4128 +/- ##
==========================================
+ Coverage 64.22% 64.46% +0.23%
==========================================
Files 36 37 +1
Lines 1873 1891 +18
Branches 379 380 +1
==========================================
+ Hits 1203 1219 +16
- Misses 569 571 +2
Partials 101 101
Continue to review full report at Codecov.
|
✨ Coder.com for PR #4128 deployed! It will be updated on every commit.
|
Heads-up: Trivy failed due to a vulnerability. I will fix in a separate branch and you can rebase once it's merged in |
The PR has been merged! Please rebase on |
@@ -28,7 +28,8 @@ | |||
"ms-vscode.remotehub", | |||
"ms-vscode.remotehub-insiders", | |||
"GitHub.remotehub", | |||
"GitHub.remotehub-insiders" | |||
"GitHub.remotehub-insiders", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylecarbs This will need to be adjusted in https://github.com/cdr/vscode/blob/code-server/product.json
and merged into the code-server
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Doing it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'll tackle this after the all-hands. Gotta prep!
Feel free to tackle if you have time!
Tracked in #4171 |
No description provided.