-
Notifications
You must be signed in to change notification settings - Fork 6k
Add linkup command to improve link functionality #4171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fdd243
to
0a3b3a3
Compare
✨ Coder.com for PR #4171 deployed! It will be updated on every commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks good but probably want a second opinion from @kylecarbs (plus CI is failing)
Do we need to update the |
This PR likely needs to be rebased and updated with the latest vscode commit.
…Sent from my iPhone
On Sep 17, 2021, at 17:46, Joe Previte ***@***.***> wrote:
error Your lockfile needs to be updated, but yarn was run with --frozen-lockfile.
Do we need to update the yarn.lock file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Codecov Report
@@ Coverage Diff @@
## main #4171 +/- ##
==========================================
+ Coverage 64.22% 65.17% +0.94%
==========================================
Files 36 37 +1
Lines 1873 1898 +25
Branches 379 382 +3
==========================================
+ Hits 1203 1237 +34
+ Misses 569 562 -7
+ Partials 101 99 -2
Continue to review full report at Codecov.
|
I wasn't sure what you meant by "updated with the latest vscode commit": Option 1
Option 2
Option 3.
I rebased and went with Option 3: I hope that's right. I'll wait for you to check before we merge this. |
Tentatively resolved in #4010 |
TBD