Fix marketplace in CLI #4301
Merged
Fix marketplace in CLI #4301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix error logging from child process.
|
✨ Coder.com for PR #4301 deployed! It will be updated on every commit.
|
jawnsy
reviewed
Oct 4, 2021
| @@ -22,8 +22,8 @@ export const runVsCodeCli = async (args: DefaultedArgs): Promise<void> => { | |||
|
|
|||
| try { | |||
| await cliProcessMain(args) | |||
| } catch (error) { | |||
| logger.error("Got error from VS Code", field("error", error)) | |||
| } catch (error: any) { | |||
There was a problem hiding this comment.
just curious, are there root error types in Node or TypeScript that we can use instead of any? seems unfortunate not to have any type information
There was a problem hiding this comment.
I think it's traditionally been any unfortunately. But in TypeScript 4.0, they allow you to type it as unknown which they say is safer. But yeah, it's too bad they don't tell us which error this is.
jsjoeio
approved these changes
Oct 4, 2021
| @@ -22,8 +22,8 @@ export const runVsCodeCli = async (args: DefaultedArgs): Promise<void> => { | |||
|
|
|||
| try { | |||
| await cliProcessMain(args) | |||
| } catch (error) { | |||
| logger.error("Got error from VS Code", field("error", error)) | |||
| } catch (error: any) { | |||
There was a problem hiding this comment.
I think it's traditionally been any unfortunately. But in TypeScript 4.0, they allow you to type it as unknown which they say is safer. But yeah, it's too bad they don't tell us which error this is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where our marketplace modifications are not applied to the CLI.