Skip to content

Fix marketplace in CLI #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Fix marketplace in CLI #4301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/node/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export const runVsCodeCli = async (args: DefaultedArgs): Promise<void> => {

try {
await cliProcessMain(args)
} catch (error) {
logger.error("Got error from VS Code", field("error", error))
} catch (error: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, are there root error types in Node or TypeScript that we can use instead of any? seems unfortunate not to have any type information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's traditionally been any unfortunately. But in TypeScript 4.0, they allow you to type it as unknown which they say is safer. But yeah, it's too bad they don't tell us which error this is.

logger.error("Got error from VS Code", error)
}

process.exit(0)
Expand Down
2 changes: 1 addition & 1 deletion vendor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"postinstall": "./postinstall.sh"
},
"devDependencies": {
"code-oss-dev": "cdr/vscode#ac74ac1220ad3016159c65ed5d6581ab88ab43be"
"code-oss-dev": "cdr/vscode#65b2462c212d415fbf521489307e58e5b691818b"
}
}
4 changes: 2 additions & 2 deletions vendor/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,9 @@ clone-response@^1.0.2:
dependencies:
mimic-response "^1.0.0"

code-oss-dev@cdr/vscode#ac74ac1220ad3016159c65ed5d6581ab88ab43be:
code-oss-dev@cdr/vscode#65b2462c212d415fbf521489307e58e5b691818b:
version "1.60.2"
resolved "https://codeload.github.com/cdr/vscode/tar.gz/ac74ac1220ad3016159c65ed5d6581ab88ab43be"
resolved "https://codeload.github.com/cdr/vscode/tar.gz/65b2462c212d415fbf521489307e58e5b691818b"
dependencies:
"@microsoft/applicationinsights-web" "^2.6.4"
"@vscode/sqlite3" "4.0.12"
Expand Down