Skip to content

Drop duplicate Helm values from values.yaml #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2021
Merged

Drop duplicate Helm values from values.yaml #4450

merged 4 commits into from
Nov 5, 2021

Conversation

Matthew-Beckett
Copy link
Contributor

Fixes #4441

  • Drop duplicate PodSecurityContext usage
  • Drop duplicate ServiceAccount usage

Matthew-Beckett and others added 2 commits November 4, 2021 16:26
@Matthew-Beckett
Drop duplicate Helm values from values.yaml
3861490
@code-asher
Use frozen lockfile for test dependencies in CI (coder#4442)
03651e5 
* Use frozen lockfile for test dependencies in CI

This might be causing more Playwright issues.

* Bump Playwright

Mostly just to trigger a reinstall of dependencies since it is cached
and still failing.

Once updated it errors saying install needs to run so add that too.
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #4450 (e0971ad) into main (219cad1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4450   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files          30       30           
  Lines        1602     1602           
  Branches      315      315           
=======================================
  Hits         1058     1058           
  Misses        466      466           
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219cad1...e0971ad. Read the comment docs.

@jsjoeio jsjoeio self-assigned this Nov 4, 2021
jsjoeio
jsjoeio approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing this so quickly! ♥️

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 4, 2021

I think we just merged a PR that fixes the e2e tests so maybe you can rebase onto main? I would do it but I'm not sure if it will let me 🤔

@Matthew-Beckett Matthew-Beckett requested a review from a team as a code owner November 4, 2021 17:34
@Matthew-Beckett Matthew-Beckett requested review from jsjoeio and removed request for a team November 4, 2021 17:34
jsjoeio
jsjoeio approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 Please work!

@Matthew-Beckett
Copy link
Contributor Author

Matthew-Beckett commented Nov 5, 2021 •
edited
Loading

@jsjoeio is this ready for merge? I don't want main getting too far out of sync and having to do a fat rebase again 😅

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 5, 2021

Yes! Thanks for the bump! Merging :D

@jsjoeio jsjoeio merged commit 94b2774 into coder:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicate values in helm chart example
3 participants
@Matthew-Beckett @jsjoeio @code-asher