Skip to content

Use frozen lockfile for test dependencies in CI #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

code-asher
Copy link
Member

This might be causing more Playwright issues.

@code-asher code-asher requested a review from a team as a code owner November 3, 2021 23:31
This might be causing more Playwright issues.
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #4442 (ed78911) into main (dcc9cf3) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4442      +/-   ##
==========================================
- Coverage   66.29%   66.04%   -0.26%     
==========================================
  Files          31       30       -1     
  Lines        1620     1602      -18     
  Branches      316      315       -1     
==========================================
- Hits         1074     1058      -16     
+ Misses        468      466       -2     
  Partials       78       78              
Impacted Files Coverage Δ
src/node/main.ts 43.61% <0.00%> (-3.96%) ⬇️
src/node/link.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc9cf3...ed78911. Read the comment docs.

Mostly just to trigger a reinstall of dependencies since it is cached
and still failing.

Once updated it errors saying install needs to run so add that too.
@code-asher code-asher force-pushed the frozen-lockfile-test branch from a80b6f2 to ed78911 Compare November 4, 2021 02:17
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked!!

@code-asher code-asher merged commit 03651e5 into coder:main Nov 4, 2021
@code-asher code-asher deleted the frozen-lockfile-test branch November 4, 2021 16:39
jsjoeio pushed a commit that referenced this pull request Nov 5, 2021
* Drop duplicate Helm values from values.yaml

* Use frozen lockfile for test dependencies in CI (#4442)

* Use frozen lockfile for test dependencies in CI

This might be causing more Playwright issues.

* Bump Playwright

Mostly just to trigger a reinstall of dependencies since it is cached
and still failing.

Once updated it errors saying install needs to run so add that too.

* Drop duplicate Helm values from values.yaml

Co-authored-by: Asher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants