-
Notifications
You must be signed in to change notification settings - Fork 3
Add code linking to release posts #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tourmaline-marshmallow-241b40 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might still need to add downlit to renv.lock
? Or is this handled by quarto?
Thanks for the review! 😊 Good question - I went back and double checked, as I could not remember exactly. Here is the log: > renv::load()
- Project '~/git/epiverse-trace.github.io' loaded. [renv 1.1.2]
> renv::status()
No issues found -- the project is in a consistent state.
> install.packages('downlit')
The following package(s) will be installed:
- downlit [0.4.4]
These packages will be installed into "~/git/epiverse-trace.github.io/renv/library/macos/R-4.4/aarch64-apple-darwin24.2.0".
Do you want to proceed? [Y/n]: y
# Installing packages --------------------------------------------------------
- Installing downlit ... OK [linked from cache]
Successfully installed 1 package in 11 milliseconds.
> renv::status()
No issues found -- the project is in a consistent state. From this, I would gather that the lockfile is okay. Do you have additional thoughts on this given this information? I keep missing minor details in |
The code above only shows that downlit is not currently in Given https://github.com/quarto-dev/quarto-cli/blob/a47d119b83895f5c036317c6c0885bb237e11df5/src/resources/rmd/rmd.R#L137-L140, I think it should be added. renv doesn't use a completely airtight sandbox by default so it's possible that the system copy of downlit is still used in your local tests. |
This PR adds automated code linking to the release posts.
I am more confident about this PR, as it builds on my last version #373, and simplifies the procedures. Specifically:
posts/
folder)renv
testing was more reliable in terms of outputProbably a few other things. Ultimately, this is tested when it runs, and I will revisit this in day or two to see whether I have new insights.