Provide Function Name in Code File #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How one would know the right name of the function used in test file?, I made function name just `hamming ()` and ran, it failed all test cases, then I checked test file and came to know the function name should be `hamming-distance ()`, so it should be given in code file, like it is provided in other languages.
|
I agree with this. I'm happy to merge this, but it would be even more awesome if you could apply this to the other exercises too. Would you be willing to do that? No worries if not. |
|
Yes! I will apply it to all the other exercises. |
I'm new to emacs lisp and I struggled running tests with just `ert`, then I came to know to run `eval-buffer` on test file, before running `ert`, so I added this. If its common to other emacs lisp users, this update can be ignored.
|
I've completed adding functions to all the code files and checked them all twice and fixed all typos I did. Handed over to review and merge team. (I was in hurry and pressed close pull request instead of comment 😂) |
ErikSchierboom
approved these changes
Oct 4, 2022
|
Great work! Thanks. |
fapdash
added a commit
to fapdash/exercism--emacs-lisp
that referenced
this pull request
Oct 5, 2022
- https://github.com/exercism/emacs-lisp/blob/8848da5d17e639f61bb9840fd55d12ee5b1873f3/.github/workflows/ci.yml didn't exit with an error code if exercise tests where failing - This was noticed because the tests for exercism#210 did fail but the bash script didn't register the failure.
fapdash
added a commit
to fapdash/exercism--emacs-lisp
that referenced
this pull request
Oct 5, 2022
- https://github.com/exercism/emacs-lisp/blob/8848da5d17e639f61bb9840fd55d12ee5b1873f3/.github/workflows/ci.yml didn't exit with an error code if exercise tests where failing - This was noticed because the tests for exercism#210 did fail but the bash script didn't register the failure.
ErikSchierboom
pushed a commit
that referenced
this pull request
Oct 6, 2022
- https://github.com/exercism/emacs-lisp/blob/8848da5d17e639f61bb9840fd55d12ee5b1873f3/.github/workflows/ci.yml didn't exit with an error code if exercise tests where failing - This was noticed because the tests for #210 did fail but the bash script didn't register the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How one would know the right name of the function used in test file?, I made function name just
hamming ()and ran, it failed all test cases, then I checked test file and came to know the function name should behamming-distance (), so it should be given in code file, like it is provided in other languages.