Fix: GHA ci.yml doesn't fail if exercise tests are failing #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure of |
ErikSchierboom
approved these changes
Oct 5, 2022
|
@fapdash Could you rebase? |
- https://github.com/exercism/emacs-lisp/blob/8848da5d17e639f61bb9840fd55d12ee5b1873f3/.github/workflows/ci.yml didn't exit with an error code if exercise tests where failing - This was noticed because the tests for exercism#210 did fail but the bash script didn't register the failure.
fapdash
force-pushed
the
fix-ci-never-failing
branch
from
6fa7b64 to
e6e1a9d
Compare
ErikSchierboom
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/exercism/emacs-lisp/blob/8848da5d17e639f61bb9840fd55d12ee5b1873f3/.github/workflows/ci.yml
didn't exit with an error code if exercise tests where failing