Skip to content

Add fast_arrayrev Function for Efficient List Reversal #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sadhiin
Copy link
Contributor

@sadhiin sadhiin commented Oct 10, 2024

PR Title: Add fast_arrayrev Function for Efficient List Reversal

Description:

This PR introduces the fast_arrayrev function, which efficiently reverses the elements of a given list using Python's slicing feature.

Changes Made:

  • Added fast_arrayrev function that:
    • Accepts a list as input.
    • Returns a new list with the elements in reverse order.
    • Utilizes slicing (array[::-1]) for optimal performance.

Benefits:

  • Provides a concise and efficient method for reversing lists.
  • Enhances code readability and maintainability.

Notes:

  • The function is straightforward and leverages Python's built-in capabilities, making it both fast and easy to use.

Source: https://www.geeksforgeeks.org/python-reversed-vs-1-which-one-is-faster/

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 11, 2024

@extinctsion
Hi buddy,
Could you please take a moment to review my PR #90 . I appreciate your feedback!

Thank you!

@extinctsion
Copy link
Owner

Hi @sadhiin thank you for participating in hacktoberfest! I appreciate you for contributing to the open-source community. I will mark this PR as hacktoberfest-accepted and please sit back and relax while we review this PR. Have a good day! Happy coding!

@extinctsion
Copy link
Owner

@sadhiin can you pls check why this pr is failing test cases? can you fix it?

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 16, 2024

@sadhiin can you pls check why this pr is failing test cases? can you fix it?

The error is causing after running this pip install . command.
It's not able to taking the version from setup.py.

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 17, 2024

@extinctsion
Hi buddy, please have a look on issue #92 and PR #93 for the solution of not properly running github action.

@extinctsion
Copy link
Owner

Hi @sadhiin, the github workflows are still getting failed. pls check.

@extinctsion
Copy link
Owner

Hi buddy, recently we have fixed the checks issue, I would recommend you to pls take pull from main branch and merge it with you branch and then again push. This would resolve the pipeline issue. I'll then merge your code after review

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 25, 2024

Sure

Adding new updated code for github action and this branch code
@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 28, 2024

Hi buddy, recently we have fixed the checks issue, I would recommend you to pls take pull from main branch and merge it with you branch and then again push. This would resolve the pipeline issue. I'll then merge your code after review

Update done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants