-
-
Notifications
You must be signed in to change notification settings - Fork 38
Sadhiin/setup issue and github action failed #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on with proper docstring explaination.
…and publish as pypi package
Hi @sadhiin, still the tests are failing. can you look into this issue? |
|
Again failing test cases @sadhiin. it says
|
On it. |
It's perfectly working on local Let's see, things should work fine. |
Hi @extinctsion please have a look no this version. |
Yes it worked. Pls mention this PR in the issue so that I can or you can mark the issue as closed |
Thanks @sadhiin for fixing this issue. It saved us a lot of time. Thanks again for this PR. Hopes this fixes the pipelines issue |
It's always fun to contribute.....! 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have approved on the fact that the pipelines are back to normal and giving expected results
Automated Version Management for setup.py #92
This PR addresses the issue of consistent version incrementing in our
setup.py
file.Changes
get_pypi_version()
function to fetch the latest version from PyPIincrement_version()
to properly increment version numbersget_version()
to use PyPI version as a base and incorporate git informationTesting
Notes for Reviewers
Dependency Changes
requests
library to project dependenciesRelated Issue
Closes #92