Skip to content

Sadhiin/setup issue and github action failed #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

sadhiin
Copy link
Contributor

@sadhiin sadhiin commented Oct 16, 2024

Automated Version Management for setup.py #92

This PR addresses the issue of consistent version incrementing in our setup.py file.

Changes

  • Added get_pypi_version() function to fetch the latest version from PyPI
  • Implemented increment_version() to properly increment version numbers
  • Updated get_version() to use PyPI version as a base and incorporate git information
  • Modified setup() to use the new versioning system

Testing

  • Tested locally with and without git tags
  • Verified version increments correctly from PyPI version
  • Checked compatibility with existing git-based versioning

Notes for Reviewers

  • Please check if the version incrementing logic meets our needs
  • Verify that the PyPI version fetching is robust enough
  • Consider any potential impacts on our CI/CD pipeline

Dependency Changes

  • Added requests library to project dependencies

Related Issue

Closes #92

@extinctsion
Copy link
Owner

Hi @sadhiin, still the tests are failing. can you look into this issue?

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 18, 2024

Hi @sadhiin, Still, the tests are failing. can you look into this issue?
Hi @extinctsion
Yes they are! It's not installed on request library. Give me a moment I'll fix it.

@extinctsion
Copy link
Owner

Again failing test cases @sadhiin. it says

File "<string>", line 6, in <module> ModuleNotFoundError: No module named 'requests' [end of output]

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 19, 2024

Again failing test cases @sadhiin. it says

File "<string>", line 6, in <module> ModuleNotFoundError: No module named 'requests' [end of output]

On it.

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 19, 2024

Again failing test cases @sadhiin. it says

File "<string>", line 6, in <module> ModuleNotFoundError: No module named 'requests' [end of output]

It's perfectly working on local
image

Let's see, things should work fine.

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 19, 2024

Hi @extinctsion please have a look no this version.

@extinctsion
Copy link
Owner

Yes it worked. Pls mention this PR in the issue so that I can or you can mark the issue as closed

@extinctsion
Copy link
Owner

Thanks @sadhiin for fixing this issue. It saved us a lot of time. Thanks again for this PR. Hopes this fixes the pipelines issue

@sadhiin
Copy link
Contributor Author

sadhiin commented Oct 25, 2024

Thanks @sadhiin for fixing this issue. It saved us a lot of time. Thanks again for this PR. Hopes this fixes the pipelines issue

It's always fun to contribute.....! 👍🏼

Copy link
Owner

@extinctsion extinctsion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved on the fact that the pipelines are back to normal and giving expected results

@extinctsion extinctsion merged commit d2430f8 into extinctsion:master Oct 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Improve Version Management in setup.py
2 participants