-
Notifications
You must be signed in to change notification settings - Fork 212
Add RESET_VALUE configuration value as sentinel value to reset a config option. #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f51a6c
to
21552ea
Compare
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Merged
This was referenced Oct 4, 2022
Merged
TheIronDev
reviewed
Oct 5, 2022
TheIronDev
reviewed
Oct 5, 2022
TheIronDev
reviewed
Oct 5, 2022
TheIronDev
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few questions to make sure some changes were intentional, otherwise LGTM
colerogers
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allowing
null
s to reset a configuration value, we are introducing a new sentinel value,RESET_VALUE
to make it clear the intention of resetting the config value to platform default:Majority of this PR concerns fixing/updating typings on various configuration options.
Recall that in v2, we inlined/repeat all function options in each respective providers to make reference doc more clear. This unfortunately bloated up this PR since I had to repeat the changes in each and every provider.