-
Notifications
You must be signed in to change notification settings - Fork 212
Add new option to preserveExternalChanges. #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bc841b1
to
ef0e5d8
Compare
6ebb3e4
to
979f186
Compare
979f186
to
7198471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since spec/v1/providers/fixtures.ts
is empty, can we remove it?
@@ -0,0 +1,13 @@ | |||
import { ManifestEndpoint } from "../src/runtime/manifest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing copyright notice, maybe we can have the linter add things like this?
* @internal | ||
*/ | ||
export type ResettableKeys<T> = Required<{ | ||
[K in keyof T as [ResetValue] extends [T[K]] ? K : never]: null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta love ts.
connector: string | Expression<string>; | ||
egressSettings?: string | Expression<string> | ResetValue; | ||
} | ||
| ResetValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reset of the whole vpc setting, just removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset of the whole thing.
@colerogers It's used in the subsequent PR. Bad PR split! |
aab136a
to
8c63b28
Compare
Fix all test cases that were broken by #1253.
This PR make some sweeping changes!
RESET_VALUE
. Practically, this means that given a function configuration like this:And you go ahead and change the memory configuration of the function using GCP Console or
gcloud
tool, we will revert the memory back to platform default on the next function deploy.preserveExternalChanges
option:This change broke a lot of test. I broke up the change for fixing test cases in a separate PR #1254.