-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add sample for onCallGenkit
#1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tagging issue was temporarily solved in firebase/firebase-tools#8127 full fix in https://www.google.com/url?q=https://github.com/firebase/firebase-tools/pull/8135&sa=D&source=docs&ust=1738351130584076&usg=AOvVaw0SL0m38qeHnFda8HLqfWro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That IS a lot of tags! But if you have mapped them to the existing snippets, that makes a world of sense.
Though we are inconsistent about it in other samples, it would be great to have basic punctuation in any comments that are displayed in the docs -- mainly periods in this file.
Are you game to do an add-periods scrub, and then if I can find anything else I'll comment specifically? Thanks Jeff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Eager to get the snippets generated. :)
I've added punctuation and clarified some comments - going to merge now so you can generate snippets! |
There are a lot of snippet tags in here because I want to make sure we can get close to matching all the snippets currently hardcoded into https://github.com/firebase/genkit/blob/main/docs/firebase.md