build(profiling-node): make sure debug build plugin is used #10534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
JonasBa,
a team,
stephanie-anderson and
lforst
and removed request for
a team
3 tasks
|
busting cache and then re-running |
This reverts commit 6c617a6.
JoeKarow
added a commit
to weareinreach/InReach
that referenced
this pull request
Feb 6, 2024
kodiakhq bot
pushed a commit
to weareinreach/InReach
that referenced
this pull request
Feb 6, 2024
* fix(app): update all non-major dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * update @sentry/profiling-node (#1068) * update integrations * add @sentry/profiling-node to serverComponentsExternalPackages * revert until getsentry/sentry-javascript#10534 merged & released --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Joe Karow <[email protected]>
|
So the test is failing https://github.com/getsentry/sentry-javascript/actions/runs/7805852389/job/21293099723?pr=10534 
but locally it clearly is being built, so there is some caching issue 
|
thank you CI 😭 |
mydea
pushed a commit
that referenced
this pull request
Feb 7, 2024
Fixes #10525 When writing the rollup config, we didn't include the debug build plugin. This led to things not be replaced properly as `profiling-node` bundles everything into a single file. This was also causing issues in our CI: https://github.com/getsentry/sentry-javascript/actions/runs/7804351046/job/21287026518?pr=10527 Backporting this fix to v7 so we can do a `7.100.1` release after we merge this in.
Merged
This was referenced Feb 12, 2024
This was referenced Mar 12, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10525
When writing the rollup config, we didn't include the debug build plugin. This led to things not be replaced properly as
profiling-nodebundles everything into a single file.This was also causing issues in our CI: https://github.com/getsentry/sentry-javascript/actions/runs/7804351046/job/21287026518?pr=10527
Backporting this fix to v7 so we can do a
7.100.1release after we merge this in.