fix(nextjs): Use passthrough createReduxEnhancer on server
#11005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Mar 11, 2024
| "ts-node": "10.9.1", | ||
| "@playwright/test": "^1.27.1" | ||
| "typescript": "4.9.5", | ||
| "wait-port": "1.0.4" |
There was a problem hiding this comment.
just to clarify, are these new deps important/needed?
There was a problem hiding this comment.
They're not new. Yarn just auto sorted them. The only thing I did was bump the version the default e2e tests run with to the latest version. I think that is needed. At least it was to verify this bug.
mydea
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #10366
In #9854 we added
createReduxEnhancerto the serverside Next.js SDK. This import pulls in all side-effects of the@sentry/reactSDK. One side-effect is that theProfilerclass has a static initializer, meaning it ends up in the server bundle- This now turns out to be a problem because Next.js does not seem to strip the Profiler class away (even if it is unused), and it crashes because it extendsReact.Componentwhich is not available in the Next.js App Router server context.We solve this by "vendoring" a noop redux enhancer instead of exporting the one from
@sentry/react.