Skip to content

fix(nextjs): Export createReduxEnhancer #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix(nextjs): Export createReduxEnhancer #9854

merged 2 commits into from
Dec 18, 2023

Conversation

adam187
Copy link
Contributor

@adam187 adam187 commented Dec 14, 2023 •
edited
Loading

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #7040

@adam187 adam187 mentioned this pull request Dec 14, 2023
Closed
3 tasks
@AbhiPrasad AbhiPrasad requested a review from lforst December 15, 2023 14:51
lforst
lforst approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember vaguely having a reason to not just do this but I don't remember it. Maybe we have solved the underlying reason architecturally by now...

@lforst lforst enabled auto-merge (squash) December 18, 2023 08:34
@lforst lforst changed the title fix(nextjs): export createReduxEnhancer fix(nextjs): Export createReduxEnhancer Dec 18, 2023
@lforst lforst merged commit 12c146b into getsentry:develop Dec 18, 2023
@lforst lforst mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createReduxEnhancer is not a function when using @sentry/nextjs with sentryReduxEnhancer
2 participants
@adam187 @lforst