-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(replay): Skip flaky replay integration test #11110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AbhiPrasad have you seen |
I don't have any recent examples, let me try to find some. I just reached for what were the open issues. |
huh flaky test detector complaining the following as well:
|
Could we find a way to skip some tests only on PRs but run them on develop/release, I wonder? Would maybe be an OK compromise for some of the more flaky tests... |
@billyvg I think you pr indeed fixed the flakes for the request size test. I don't recall it flaking in a very long time. Gonna remove the skip in this pr and merge the other skip. |
Also, nevermind, here's a response body flake: https://github.com/getsentry/sentry-javascript/actions/runs/8294176805/job/22698723842?pr=11097#step:10:127 |
This reverts commit 2c6020b.
size-limit report 📦
|
ref #11062