Skip to content

test(replay): Skip flaky replay integration test #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 14, 2024

ref #11062

@AbhiPrasad AbhiPrasad requested a review from billyvg March 14, 2024 21:52
@billyvg
Copy link
Member

billyvg commented Mar 14, 2024

@AbhiPrasad have you seen replay/extendNetworkBreadcrumbs/xhr/captureRequestSize flake? I could try applying what I did in #10777 to these tests as well but it's hard to track how stable tests are

@AbhiPrasad
Copy link
Member Author

have you seen replay/extendNetworkBreadcrumbs/xhr/captureRequestSize flake

I don't have any recent examples, let me try to find some. I just reached for what were the open issues.

@AbhiPrasad
Copy link
Member Author

huh flaky test detector complaining the following as well:

  2 failed
    [webkit] › suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts:255:11 › captures request headers as Headers instance 
    [webkit] › suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts:98:11 › captures request size from non-text request body 

@mydea
Copy link
Member

mydea commented Mar 15, 2024

Could we find a way to skip some tests only on PRs but run them on develop/release, I wonder? Would maybe be an OK compromise for some of the more flaky tests...

@lforst
Copy link
Contributor

lforst commented Mar 15, 2024

@billyvg I think you pr indeed fixed the flakes for the request size test. I don't recall it flaking in a very long time. Gonna remove the skip in this pr and merge the other skip.

@lforst lforst enabled auto-merge (squash) March 15, 2024 09:31
@lforst lforst disabled auto-merge March 15, 2024 09:31
@lforst lforst changed the title test(replay): Skip flaky replay integration tests test(replay): Skip flaky replay integration test Mar 15, 2024
@lforst lforst enabled auto-merge (squash) March 15, 2024 09:31
@lforst
Copy link
Contributor

lforst commented Mar 15, 2024

@lforst
Copy link
Contributor

lforst commented Mar 15, 2024

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.98 KB (added)
@sentry/browser (incl. Tracing, Replay) 78.5 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 81.82 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 72.09 KB (added)
@sentry/browser (incl. Tracing) 78.5 KB (added)
@sentry/browser (incl. browserTracingIntegration) 78.5 KB (added)
@sentry/browser (incl. feedbackIntegration) 76.45 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 76.64 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 76.65 KB (added)
@sentry/browser (incl. sendFeedback) 72.52 KB (added)
@sentry/browser 71.95 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.62 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.48 KB (added)
CDN Bundle (incl. Tracing) 37.82 KB (added)
CDN Bundle 25.68 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.12 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.06 KB (added)
CDN Bundle - uncompressed 75.9 KB (added)
@sentry/react (incl. Tracing, Replay) 80.46 KB (added)
@sentry/react 73.93 KB (added)

@lforst lforst merged commit c045dcb into develop Mar 15, 2024
@lforst lforst deleted the abhi-skip-flaky-replay-tests branch March 15, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants