Skip to content

test(replay): Skip flaky replay integration test #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2024
Merged

test(replay): Skip flaky replay integration test #11110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80a9ef6
test(replay): Skip flaky replay integration tests
AbhiPrasad Mar 14, 2024
fe56cfc
disable more tests
AbhiPrasad Mar 14, 2024
2224f7a
Merge branch 'develop' into abhi-skip-flaky-replay-tests
lforst Mar 15, 2024
2c6020b
Unskip non-flakey test
lforst Mar 15, 2024
e4ae858
Revert "Unskip non-flakey test"
lforst Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import {
shouldSkipReplayTest,
} from '../../../../../utils/replayHelpers';

sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, page, browserName }) => {
// Skipping because this test is flaky
// https://github.com/getsentry/sentry-javascript/issues/11062
sentryTest.skip('handles empty/missing request headers', async ({ getLocalTestPath, page, browserName }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down Expand Up @@ -250,7 +252,9 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
]);
});

sentryTest('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
// This test is flaky.
// See https://github.com/getsentry/sentry-javascript/pull/11110
sentryTest.skip('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down
8 changes: 6 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import {
shouldSkipReplayTest,
} from '../../../../../utils/replayHelpers';

sentryTest('captures request body size when body is sent', async ({ getLocalTestPath, page }) => {
// Skipping because this test is flaky
// https://github.com/getsentry/sentry-javascript/issues/10395
sentryTest.skip('captures request body size when body is sent', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down Expand Up @@ -93,7 +95,9 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
]);
});

sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
// This test is flaky.
// See https://github.com/getsentry/sentry-javascript/pull/11110
sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down