Skip to content

feat(aws-serverless): Remove deprecated rethrowAfterCapture option #11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat(aws-serverless): Remove deprecated rethrowAfterCapture option #11126

merged 2 commits into from
Mar 18, 2024

Conversation

AbhiPrasad
Copy link
Member

The rethrowAfterCapture option was deprecated in #4448, which was released in 6.17.2. This finally removes the option.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and s1gr1d and removed request for a team March 15, 2024 13:56
@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 15, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.29 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.62 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.43 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.17 KB (added)
@sentry/browser (incl. Tracing) 38.25 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.25 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.11 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.2 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.21 KB (added)
@sentry/browser (incl. sendFeedback) 29.17 KB (added)
@sentry/browser 24.35 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.62 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.48 KB (added)
CDN Bundle (incl. Tracing) 37.82 KB (added)
CDN Bundle 25.68 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.12 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.06 KB (added)
CDN Bundle - uncompressed 75.9 KB (added)
@sentry/react (incl. Tracing, Replay) 73.61 KB (added)
@sentry/react 24.37 KB (added)

s1gr1d
s1gr1d approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@AbhiPrasad AbhiPrasad merged commit 7eed1ef into develop Mar 18, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-aws-serverless-rethrowAfterCapture branch March 18, 2024 14:24
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(aws-serverless): Remove deprecated rethrowAfterCapture option (g…
a33eb70 
…etsentry#11126)

The `rethrowAfterCapture` option was deprecated in
getsentry#4448, which was
released in `6.17.2`. This finally removes the option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1gr1d s1gr1d s1gr1d approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @s1gr1d