Skip to content

feat(aws-serverless): Remove deprecated rethrowAfterCapture option #11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ To make sure these integrations work properly you'll have to change how you
- [Next.js SDK](./MIGRATION.md#nextjs-sdk)
- [SvelteKit SDK](./MIGRATION.md#sveltekit-sdk)
- [Astro SDK](./MIGRATION.md#astro-sdk)
- [AWS Serverless SDK](./MIGRATION.md#aws-serverless-sdk)

### General

Expand Down Expand Up @@ -613,6 +614,10 @@ Removed top-level exports: `withSentryApi`, `withSentryAPI`, `withSentryGetServe
`IS_BUILD`, `isBuild`

- [Removal of deprecated API in `@sentry/nextjs`](./MIGRATION.md#removal-of-deprecated-api-in-sentrynextjs)
- [Updated minimum compatible Next.js version to `13.2.0`](./MIGRATION.md#updated-minimum-compatible-nextjs-version-to-1320)
- [Merging of the Sentry Webpack Plugin options and SDK Build options](./MIGRATION.md#merging-of-the-sentry-webpack-plugin-options-and-sdk-build-options)
- [Removal of the `sentry` property in your Next.js options (next.config.js)](./MIGRATION.md#removal-of-the-sentry-property-in-your-nextjs-options-nextconfigjs)
- [Updated the `@sentry/webpack-plugin` dependency to version 2](./MIGRATION.md#updated-the-sentry-webpack-plugin-dependency-to-version-2)

#### Removal of deprecated API in `@sentry/nextjs`

Expand Down Expand Up @@ -715,6 +720,8 @@ or look at the TypeScript type definitions of `withSentryConfig`.

### Astro SDK

- [Removal of `trackHeaders` option for Astro middleware](./MIGRATION.md#removal-of-trackheaders-option-for-astro-middleware)

#### Removal of `trackHeaders` option for Astro middleware

Instead of opting-in via the middleware config, you can configure if headers should be captured via
Expand All @@ -734,6 +741,8 @@ Sentry.init({

### SvelteKit SDK

- [Breaking `sentrySvelteKit()` changes](./MIGRATION.md#breaking-sentrysveltekit-changes)

#### Breaking `sentrySvelteKit()` changes

We upgraded the `@sentry/vite-plugin` which is a dependency of the SvelteKit SDK from version 0.x to 2.x. With this
Expand Down Expand Up @@ -806,6 +815,15 @@ sentrySvelteKit({
Important: we DO NOT guarantee stability of `unstable_sentryVitePluginOptions`. They can be removed or updated at any
time, including breaking changes within the same major version of the SDK.

### AWS Serverless SDK

- [Removal of `rethrowAfterCapture` option](./MIGRATION.md#removal-of-rethrowaftercapture-option)

#### Removal of `rethrowAfterCapture` option

In `v6.17.2` the `rethrowAfterCapture` option to `wrapHandler` was deprecated. In `v8` it has been removed. There is no
replacement API.

## 5. Behaviour Changes

- [Updated behaviour of `tracePropagationTargets` in the browser](./MIGRATION.md#updated-behaviour-of-tracepropagationtargets-in-the-browser-http-tracing-headers--cors)
Expand Down
4 changes: 0 additions & 4 deletions packages/aws-serverless/src/awslambda.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ export type AsyncHandler<T extends Handler> = (

export interface WrapperOptions {
flushTimeout: number;
/**
* @deprecated This option is unused since v6 and will be removed in v8.
*/
rethrowAfterCapture?: boolean;
callbackWaitsForEmptyEventLoop: boolean;
captureTimeoutWarning: boolean;
timeoutWarningLimit: number;
Expand Down