test: Re-enable flaky replay tests #11140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
requested review from
billyvg,
a team,
mydea and
s1gr1d
and removed request for
a team
billyvg
approved these changes
Mar 15, 2024
billyvg
added a commit
that referenced
this pull request
Mar 15, 2024
billyvg
added a commit
that referenced
this pull request
Apr 15, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
closes getsentry#11136 closes getsentry#11062 closes getsentry#11137 closes getsentry#11138 closes getsentry#11139 In getsentry#11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here. Note that `Detect flaky tests / Check tests for flakiness` runs on the smaller workers, so it'll experience the same issues we had before.
billyvg
added a commit
that referenced
this pull request
May 13, 2024
See #11140 Closes #9119 --------- Co-authored-by: Francesco Novy <[email protected]>
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
See #11140 Closes #9119 --------- Co-authored-by: Francesco Novy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11136
closes #11062
closes #11137
closes #11138
closes #11139
In #11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here.
Note that
Detect flaky tests / Check tests for flakinessruns on the smaller workers, so it'll experience the same issues we had before.