Skip to content

test: Re-enable flaky replay tests #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

test: Re-enable flaky replay tests #11140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
]);
});

// This test is flaky.
// See https://github.com/getsentry/sentry-javascript/pull/11110
sentryTest.skip('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
sentryTest('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down
4 changes: 1 addition & 3 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,7 @@ sentryTest.skip('captures request body size when body is sent', async ({ getLoca
]);
});

// This test is flaky.
// See https://github.com/getsentry/sentry-javascript/pull/11110
sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down
4 changes: 1 addition & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
]);
});

// This test is flaky so it's skipped for now
// See https://github.com/getsentry/sentry-javascript/issues/11139
sentryTest.skip('does not capture response headers if URL does not match', async ({ getLocalTestPath, page }) => {
sentryTest('does not capture response headers if URL does not match', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down
4 changes: 1 addition & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
]);
});

// This test is flaky so it's skipped for now
// See https://github.com/getsentry/sentry-javascript/issues/11137
sentryTest.skip('captures response size from non-text response body', async ({ getLocalTestPath, page }) => {
sentryTest('captures response size from non-text response body', async ({ getLocalTestPath, page }) => {
if (shouldSkipReplayTest()) {
sentryTest.skip();
}
Expand Down
4 changes: 1 addition & 3 deletions dev-packages/browser-integration-tests/suites/tracing/metrics/handlers-lcp/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../.

const bundle = process.env.PW_BUNDLE || '';

// This test is flaky so it's skipped for now
// See https://github.com/getsentry/sentry-javascript/issues/11138
sentryTest.skip(
sentryTest(
'should capture metrics for LCP instrumentation handlers',
async ({ browserName, getLocalTestPath, page }) => {
// This uses a utility that is not exported in CDN bundles
Expand Down