Skip to content

fix(aws-serverless): Remove invalid esm/import entry point in package.json #11968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(aws-serverless): Remove invalid esm/import entry point in package.json #11968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/aws-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
"exports": {
"./package.json": "./package.json",
".": {
"import": {
"types": "./build/npm/types/index.d.ts",
"default": "./build/npm/esm/index.js"
},
Comment on lines -24 to -27
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative I guess would be to point to

"default": "./build/npm/cjs/index.js"

instead but I have no idea if this is better or would cause other issues 🤔 My gut feeling says issues because Node probably expects ESM when it resolves an import entry point (?)

"require": {
"types": "./build/npm/types/index.d.ts",
"default": "./build/npm/cjs/index.js"
Expand Down
Loading