fix(aws-serverless): Remove invalid esm/import entry point in package.json
#11968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
May 10, 2024
Comment on lines
-24
to
-27
| "import": { | ||
| "types": "./build/npm/types/index.d.ts", | ||
| "default": "./build/npm/esm/index.js" | ||
| }, |
There was a problem hiding this comment.
The alternative I guess would be to point to
"default": "./build/npm/cjs/index.js"instead but I have no idea if this is better or would cause other issues 🤔 My gut feeling says issues because Node probably expects ESM when it resolves an import entry point (?)
|
Nevermind, I was wrong, we actually support ESM now. Closing and opening another PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we intentionally removed the
esmartifacts in our@sentry/aws-serverlesspackage but still referenced them via theimportentry point in thepackage.json. This PR removes theimportentry for now until we have proper ESM support in the serverless package.Full disclaimer: I'm not sure if this is the right way to go but the alternative (see comment below) feels wrong, too.
closes #11965