fix(aws-serverless): Include ESM artifacts in package #11973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lforst
approved these changes
May 10, 2024
|
@Lms24 @lforst I don't think this completely resolves the issue (fyi). The module definition (package.json) also lists exports of: "exports": {
...
"./import": {
"import": {
"default": "./build/import-hook.mjs"
}
},
"./loader": {
"import": {
"default": "./build/loader-hook.mjs"
}
}
},While not immediately important, there is also no So maybe also include |
|
@jd-carroll Indeed not that important but still, we should fix it. Thanks for catching that. |
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Fix the `files` property in our AWS Serverless SDK `package.json` to include ESM artifacts now that we support ESM in AWS Serverless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
filesproperty in our AWS Serverless SDKpackage.jsonto include ESM artifacts now that we support ESM in AWS Serverless.(supersedes #11968)
closes #11965