Skip to content

feat(browser): option to ignore certain resource types #16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 26, 2025

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented May 26, 2025

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Contributor

github-actions bot commented May 26, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.93 kB - -
@sentry/browser - with treeshaking flags 23.7 kB - -
@sentry/browser (incl. Tracing) 38.23 kB +0.07% +25 B 🔺
@sentry/browser (incl. Tracing, Replay) 76.38 kB +0.07% +48 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.48 kB +0.06% +41 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 81.14 kB +0.06% +44 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 93.22 kB +0.04% +36 B 🔺
@sentry/browser (incl. Feedback) 40.68 kB - -
@sentry/browser (incl. sendFeedback) 28.64 kB - -
@sentry/browser (incl. FeedbackAsync) 33.53 kB - -
@sentry/react 25.71 kB - -
@sentry/react (incl. Tracing) 40.24 kB +0.11% +43 B 🔺
@sentry/vue 28.26 kB - -
@sentry/vue (incl. Tracing) 40.05 kB +0.08% +32 B 🔺
@sentry/svelte 23.95 kB - -
CDN Bundle 25.22 kB - -
CDN Bundle (incl. Tracing) 38.4 kB +0.1% +38 B 🔺
CDN Bundle (incl. Tracing, Replay) 74.26 kB +0.08% +55 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 79.69 kB +0.07% +50 B 🔺
CDN Bundle - uncompressed 73.59 kB - -
CDN Bundle (incl. Tracing) - uncompressed 113.64 kB +0.12% +126 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.61 kB +0.06% +126 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.44 kB +0.06% +126 B 🔺
@sentry/nextjs (client) 41.91 kB +0.11% +43 B 🔺
@sentry/sveltekit (client) 38.73 kB +0.09% +34 B 🔺
@sentry/node 149.82 kB +0.01% +1 B 🔺
@sentry/node - without tracing 98.09 kB - -
@sentry/aws-serverless 123.83 kB - -

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! I think this is great and it also solves #16194 (which I connected to this issue). For the future, if we find use cases for users wanting to exclude all resource spans, we could also add a boolean to the option.

@Lms24 Lms24 linked an issue May 26, 2025 that may be closed by this pull request
Copy link

codecov bot commented May 26, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error parsing JUnit XML in /home/runner/work/sentry-javascript/sentry-javascript/packages/solidstart/vitest.junit.xml at 383:33

Caused by:
    RuntimeError: Error parsing XML
    
    Caused by:
        0: ill-formed document: expected `</testsuite>`, but `</testsuite</</testsuites>` was found
        1: expected `</testsuite>`, but `</testsuite</</testsuites>` was found

For more help, visit our troubleshooting guide.

@bcoe bcoe merged commit c297bf9 into develop May 26, 2025
124 checks passed
@bcoe bcoe deleted the ignore-resource-spans branch May 26, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trackResources option to browserTracingIntegration
2 participants