ref(naming): Rename user to publicKey in Dsn type and class
#3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
kamilogorek
reviewed
Feb 2, 2021
lobsterkatie
force-pushed
the
kmclb-user-in-dsn-is-public-key
branch
from
3c62321 to
9e6e3a4
Compare
lobsterkatie
changed the title
user to publicKey in Dsn type and classuser to publicKey in Dsn type and class
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... since that's the way we refer to it everywhere else.
I included backwards compatibility, but I'm torn on whether that's even necessary, since this is deep in the SDK's internals. Interested in opinions there.UPDATE: Kept the backwards compatibility under the hood, but removed the logging, so it adapts silently.