Skip to content

ref(replay): Use WINDOW instead of window #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2022
Merged

ref(replay): Use WINDOW instead of window #6316

merged 3 commits into from
Nov 29, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 28, 2022

This PR replaces usage of window with the global WINDOW, to avoid using the window global directly.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Nov 28, 2022
@mydea mydea requested review from billyvg and Lms24 November 28, 2022 16:02
@mydea mydea self-assigned this Nov 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.76 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 63.41 KB (+0.05% 🔺)
@sentry/replay - Webpack (gzipped + minified) 63.41 KB (+0.05% 🔺)
@sentry/replay - Webpack (minified) 204.88 KB (+0.04% 🔺)

This was referenced Nov 29, 2022
Closed
Merged
@mydea
Copy link
Member Author

mydea commented Nov 29, 2022

Note: I've updated this a bit:

  • Extracted the isBrowser check into a dedicated PR
  • @sentry/browser is now a peerDependency of this package. Before, it was just an implicit relationship.

Lms24
Lms24 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size-check increase should be resolved after #6329 is merged and this is rebased

Nevermind you already did this 😅

@mydea mydea merged commit a1d1dac into master Nov 29, 2022
@mydea mydea deleted the fn/replay-WINDOW branch November 29, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mydea @billyvg @Lms24 @AbhiPrasad