examples : use xcframework in whisper.objc example #2882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking into an issue when running this example I ran into another issue when trying to capture audio which did not work for me. I've added 5afa03e which tries to address this. I'm not sure as to why this is needed now, perhaps a reason could be that when using more recent iOS versions Apple requires the session to be explicitly activated. |
This commit updates the whisper.objc example to use the xcframework. The motivation for this to be consistent with the swift example and to also act as a reference for how to use the xcframework in an objc project. Resolves: ggml-org#2881
This commit adds the setup of the audio session in the viewDidload method of the ViewController.m file. This is necessary to allow the app to record audio. The motivation for this is that without this it was not possible to caputue audio from the microphone. It was possible to click on the Capture button but nothing happened after that, and the button was not marked red indicating that the button could be clicked again to stop capturing. With this change it is possible to capture audio from the microphone and get it transcribed.
danbev
force-pushed
the
whisper-objc-xcframework
branch
from
f7bda7e to
5afa03e
Compare
ggerganov
approved these changes
Mar 17, 2025
buxuku
pushed a commit
to buxuku/whisper.cpp
that referenced
this pull request
Mar 26, 2025
* examples : use xcframework in whisper.objc example This commit updates the whisper.objc example to use the xcframework. The motivation for this to be consistent with the swift example and to also act as a reference for how to use the xcframework in an objc project. Resolves: ggml-org#2881 * examples : setup audio session viewDidload This commit adds the setup of the audio session in the viewDidload method of the ViewController.m file. This is necessary to allow the app to record audio. The motivation for this is that without this it was not possible to caputue audio from the microphone. It was possible to click on the Capture button but nothing happened after that, and the button was not marked red indicating that the button could be clicked again to stop capturing. With this change it is possible to capture audio from the microphone and get it transcribed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the whisper.objc example to use the xcframework.
The motivation for this to be consistent with the swift example and to also act as a reference for how to use the xcframework in an objc project.
Resolves: #2881