PY: deprecate a bunch of unused code #10317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -347,7 +351,9 @@ | |||
| * Holds if `bit` is a binary expression node with a bitwise operator. | |||
| * Helper for `this_binary_expr_points_to`. | |||
| */ | |||
| predicate bitwise_expression_node(BinaryExprNode bit, ControlFlowNode left, ControlFlowNode right) { | |||
| deprecated predicate bitwise_expression_node( | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter
erik-krogh
force-pushed
the
py-unqueryable
branch
from
466656b to
ebb0aa3
Compare
erik-krogh
force-pushed
the
py-unqueryable
branch
from
ebb0aa3 to
283c711
Compare
tausbn
reviewed
Sep 12, 2022
I've added a change-note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking through some of the results of this yet-to-be-merged QL-for-QL query: #8454
I know the Python teams wants to deprecate the points-to code, so I tried to see if I could deprecate some unused code in Python.
No query/test depend on any of the code I've deprecated.
There was some more code I initially tried to deprecate. However, it was being used in internal queries (that QL-for-QL can't see).