QL: detect unqueryable code #8454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
unqueryable
branch
2 times, most recently
from
905c503 to
9a419d4
Compare
MathiasVP
reviewed
Mar 16, 2022
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
Outdated
Show resolved
Hide resolved
jbj
reviewed
Mar 16, 2022
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
Outdated
Show resolved
Hide resolved
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
Outdated
Show resolved
Hide resolved
|
I reverted the
|
erik-krogh
force-pushed
the
unqueryable
branch
from
a45d535 to
5544750
Compare
erik-krogh
force-pushed
the
unqueryable
branch
from
ab78dc0 to
bd1f45e
Compare
erik-krogh
force-pushed
the
unqueryable
branch
from
bd1f45e to
c4290ce
Compare
This was referenced Sep 26, 2022
erik-krogh
force-pushed
the
unqueryable
branch
2 times, most recently
from
c2d3e80 to
0f57d94
Compare
tausbn
reviewed
Sep 29, 2022
| result.(Module).getAMember().(ClasslessPredicate).getName() = "forceStage" or | ||
| result.(ClasslessPredicate).getName() = "forceStage" or | ||
| result.(Module).getAMember().(ClasslessPredicate).getName() = | ||
| ["forceStage", "forceCachingInSameStageforceCachingInSameStage"] or |
There was a problem hiding this comment.
I feel like I'm seeing double. Should this be simply forceCachingInSameStage?
There was a problem hiding this comment.
And the case was also redundant.
The below case in the disjunction already covered it.
erik-krogh
force-pushed
the
unqueryable
branch
from
8dee962 to
74b44f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
ql/dead-code, but does not consider public APIs as live.That means any code that doesn't affect any (known) query is flagged.
The query is therefore good at detecting untested code or code that could be deprecated (:eyes: Python).
Shared files where not all languages use all the features have a tendency to be flagged, so a bunch of those have been manually excluded.
There is a whole bunch of existing alerts where unused code exists for completeness, or where the code is only used by queries outside of the
github/codeqlrepo.So even though there are plenty of results, most of the results should not be fixed.
I still think it's a nice query to have, as it has found some obvious bugs in e.g. JS and GO (see the PRs below).
PRs from this query:
Python: #10317
JS: #8422
Go: #10475
Ruby: #10476
Java: #10486
C: #10573
C#: #10584