Skip to content

Go: Fix source/sanitizer class that were never used #10475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

Go: Fix source/sanitizer class that were never used #10475

merged 2 commits into from
Sep 20, 2022

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Sep 19, 2022 •
edited
Loading

The Sanitizer class in insecure-randomness was never used. The fix was to add a isSanitizer() predicate to the configuration.

The Source class for the Xss classes was never used.
This class isn't useful with the current queries, so I've deprecated it.

Evaluation was uneventful

@erik-krogh erik-krogh mentioned this pull request Sep 19, 2022
Open
@github-actions github-actions bot added the Go label Sep 19, 2022
@erik-krogh erik-krogh marked this pull request as ready for review September 20, 2022 10:11
@erik-krogh erik-krogh requested a review from a team as a code owner September 20, 2022 10:11
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Sep 20, 2022
@erik-krogh erik-krogh merged commit cd71546 into github:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

Assignees
No one assigned
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-krogh @smowton