Skip to content

C#: deprecate/delete some unused code #10584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

erik-krogh
Copy link
Contributor

I'm looking through some of the results of this yet-to-be-merged QL-for-QL query: #8454.

The code I've deleted/deprecated is not used by any query (including test queries).

You got plenty of unused code in public libraries (for completeness I assume). I haven't touched those.

@github-actions github-actions bot added the C# label Sep 27, 2022
@erik-krogh erik-krogh marked this pull request as ready for review September 27, 2022 12:15
@erik-krogh erik-krogh requested a review from a team as a code owner September 27, 2022 12:15
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Sep 27, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erik-krogh erik-krogh merged commit b993726 into github:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants