-
Notifications
You must be signed in to change notification settings - Fork 1.7k
C# 11: Generic attributes #11814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# 11: Generic attributes #11814
Conversation
@michaelnebel It might be worth checking if the CIL extractor also supports generic attributes. We do some attribute processing in |
990a7ca
to
25019eb
Compare
25019eb
to
f506ffb
Compare
After the changes to make support for attributes on methods, I can confirm that generic attributes also works out of the box for attributes extracted from CIL. |
f506ffb
to
2772a64
Compare
Let's check with DCA too. Otherwise it looks good to me. |
👍 Yes definitely! I will take this PR out of draft and rebase as soon as its dependency has been merged and then run DCA! |
2772a64
to
4c94adb
Compare
DCA looks good! |
It turns out that the extractor supports generic attributes out of the box due to the existing reference design between attributes and types.
That is, we only need to implement some minor Code QL library functionality for generic attributes to fetch type arguments and the like.
However, as a part of the process @tamasvajk discovered that attributes on methods in CIL was not correctly extracted. With the help of @tamasvajk this is fixed in #11907