C# 11: CIL attributes #11907
Merged
C# 11: CIL attributes #11907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/cil/attributes
branch
from
a11a912 to
de3b0ee
Compare
michaelnebel
force-pushed
the
csharp/cil/attributes
branch
from
de3b0ee to
6253350
Compare
|
DCA looks good (except for the one failing projects, which is most likely spurious). I will run DCA again for that single project. |
tamasvajk
approved these changes
Jan 18, 2023
|
Follow up DCA also looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tamasvajk and I had a longer debugging session where @tamasvajk discovered that the implementation of CIL extraction for method attributes are incorrect. The lazy evaluation of
yield returncauses the theContentsfor the cil attributes never to be evaluated and thus never included in the TRAP.This is fixed in this PR.
As a part of this PR the CIL attributes test also needed to be updated to exclude attributes for
System.Diagnostics.Tracing.EventSource.<WriteEventString>as the unit test execution produced slightly different results on MacOS and Linux (related to method naming).