Skip to content

C#: Report any extracted file as successfully extracted #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Jan 17, 2024

No description provided.

@mbg mbg requested a review from a team as a code owner January 17, 2024 20:58
@mbg mbg requested a review from henrymercer January 17, 2024 21:00
owen-mc
owen-mc previously approved these changes Jan 17, 2024
henrymercer
henrymercer previously approved these changes Jan 17, 2024
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Consider renaming the title of the query to something like ExtractedFiles.ql)

tamasvajk
tamasvajk previously approved these changes Jan 18, 2024
file.fromSource() and
not exists(ExtractorError e | e.getLocation().getFile() = file) and
not exists(CompilerError e | e.getLocation().getFile() = file)
where file.fromSource()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change @name Successfully extracted files to @name Extracted files, like on #15256.

@mbg mbg dismissed stale reviews from tamasvajk, henrymercer, and owen-mc via d0003ce January 18, 2024 12:47
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbg mbg merged commit d8eef27 into main Jan 18, 2024
@mbg mbg deleted the mbg/csharp/redefine-successfully-extracted-files branch January 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants