Skip to content

C#: Report any extracted file as successfully extracted #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024
Merged

C#: Report any extracted file as successfully extracted #15360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a307918
C#: Report any extracted file as successfully extracted
mbg Jan 17, 2024
d0003ce
C#: Rename query to ExtractedFiles
mbg Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions csharp/ql/lib/change-notes/2024-01-17-csharp-successfully-extracted.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The diagnostic query `cs/diagnostics/successfully-extracted-files`, and therefore the Code Scanning UI measure of scanned C# files, now considers any C# file seen during extraction, even one with some errors, to be extracted / scanned.
7 changes: 2 additions & 5 deletions ...agnostics/DiagnosticNoExtractionErrors.ql → csharp/ql/src/Diagnostics/ExtractedFiles.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @name Successfully extracted files
* @name Extracted files
* @description A list of all files in the source code directory that were extracted
* without encountering an extraction or compiler error in the file.
* @kind diagnostic
Expand All @@ -11,8 +11,5 @@ import csharp
import semmle.code.csharp.commons.Diagnostics

from File file
where
file.fromSource() and
not exists(ExtractorError e | e.getLocation().getFile() = file) and
not exists(CompilerError e | e.getLocation().getFile() = file)
where file.fromSource()
select file, ""
1 change: 0 additions & 1 deletion csharp/ql/test/library-tests/diagnostics/DiagnosticNoExtractorErrors.expected
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion csharp/ql/test/library-tests/diagnostics/DiagnosticNoExtractorErrors.qlref
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions csharp/ql/test/library-tests/diagnostics/ExtractedFiles.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
| A.cs:0:0:0:0 | A.cs | |
| Program.cs:0:0:0:0 | Program.cs | |
1 change: 1 addition & 0 deletions csharp/ql/test/library-tests/diagnostics/ExtractedFiles.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Diagnostics/ExtractedFiles.ql