JS: refactor most library models away from AST nodes #8604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
httpNode
branch
19 times, most recently
from
c980fe5 to
e93beab
Compare
erik-krogh
changed the title
erik-krogh
force-pushed
the
httpNode
branch
3 times, most recently
from
024c690 to
ccd6525
Compare
erik-krogh
commented
Apr 3, 2022
erik-krogh
force-pushed
the
httpNode
branch
2 times, most recently
from
6b19874 to
eefcfc1
Compare
erik-krogh
changed the title
Co-authored-by: Asger F <[email protected]>
Co-authored-by: Asger F <[email protected]>
|
|
|
The new results are due to recognizing object destructuring as property reads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I started with refactoring the HTTP models to use dataflow nodes.
That was done surprisingly quick, so I continued with more library models.
I've made deprecated aliases where a renaming made sense, and otherwise I just changed the type.
The
flowsTopredicates in the HTTP models were confusing when starting to useDataFlow::Node. (I initially made mistakes because of that). So I've deprecated thoseflowsTopredicates.Evaluation
An evaluation looks OK. But there are some new results and some lost results.
New results:
All appear to be TPs, and they are all from recognizing destructuring assignments as property reads, which allows us to recognize more sources.
Two of the results appeared from refactoring the HTTP models (the
js/path-injectionresults).And two other appeared from refactoring the
SensitiveExprclass (thejs/insufficient-password-hashresutls).Lost results:
Both lost results are a consequence of a
DataFlow::PropWritehaving no result forgetRhs()when the AST looks like:One appears to be a TP, the other appears to be an FP.
I should do some followup work to investigate if we can have a sensible result for
getRhs()in the above example. (After this PR has merged).