Skip to content

Java/C: Improve performance when multiple configs use field flow. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Java/C: Improve performance when multiple configs use field flow. #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@
private predicate storeCandFwd1(Content f, Configuration config) {
exists(Node mid, Node node |
not config.isBarrier(node) and
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(mid, _, config) and
store(mid, f, node)
)
Expand Down Expand Up @@ -312,7 +312,7 @@
*/
private predicate readCand1(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(node, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd1(f, unbind(config)) and
Expand Down Expand Up @@ -548,7 +548,7 @@
*/
private predicate storeCandFwd2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCand1(node, true, unbind(config)) and
nodeCandFwd2(mid, _, _, config) and
store(mid, f, node) and
Expand Down Expand Up @@ -616,7 +616,7 @@
*/
private predicate readCand2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd2(node, _, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd2(f, unbind(config)) and
Expand Down
8 changes: 4 additions & 4 deletions cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@
private predicate storeCandFwd1(Content f, Configuration config) {
exists(Node mid, Node node |
not config.isBarrier(node) and
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(mid, _, config) and
store(mid, f, node)
)
Expand Down Expand Up @@ -312,7 +312,7 @@
*/
private predicate readCand1(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(node, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd1(f, unbind(config)) and
Expand Down Expand Up @@ -548,7 +548,7 @@
*/
private predicate storeCandFwd2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCand1(node, true, unbind(config)) and
nodeCandFwd2(mid, _, _, config) and
store(mid, f, node) and
Expand Down Expand Up @@ -616,7 +616,7 @@
*/
private predicate readCand2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd2(node, _, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd2(f, unbind(config)) and
Expand Down
8 changes: 4 additions & 4 deletions cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@
private predicate storeCandFwd1(Content f, Configuration config) {
exists(Node mid, Node node |
not config.isBarrier(node) and
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(mid, _, config) and
store(mid, f, node)
)
Expand Down Expand Up @@ -312,7 +312,7 @@
*/
private predicate readCand1(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(node, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd1(f, unbind(config)) and
Expand Down Expand Up @@ -548,7 +548,7 @@
*/
private predicate storeCandFwd2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCand1(node, true, unbind(config)) and
nodeCandFwd2(mid, _, _, config) and
store(mid, f, node) and
Expand Down Expand Up @@ -616,7 +616,7 @@
*/
private predicate readCand2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd2(node, _, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd2(f, unbind(config)) and
Expand Down
8 changes: 4 additions & 4 deletions cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@
private predicate storeCandFwd1(Content f, Configuration config) {
exists(Node mid, Node node |
not config.isBarrier(node) and
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(mid, _, config) and
store(mid, f, node)
)
Expand Down Expand Up @@ -312,7 +312,7 @@
*/
private predicate readCand1(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd1(node, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd1(f, unbind(config)) and
Expand Down Expand Up @@ -548,7 +548,7 @@
*/
private predicate storeCandFwd2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCand1(node, true, unbind(config)) and
nodeCandFwd2(mid, _, _, config) and
store(mid, f, node) and
Expand Down Expand Up @@ -616,7 +616,7 @@
*/
private predicate readCand2(Content f, Configuration config) {
exists(Node mid, Node node |
useFieldFlow(unbind(config)) and
useFieldFlow(config) and
nodeCandFwd2(node, _, true, unbind(config)) and
read(node, f, mid) and
storeCandFwd2(f, unbind(config)) and
Expand Down